From 84cf537412794b444e11c77ac8978826309aa4bd Mon Sep 17 00:00:00 2001
From: Pfingstfrosch <pfingstfrosch@gmail.com>
Date: Fri, 29 May 2020 16:12:23 +0200
Subject: [PATCH] Catch render errors and display 'Couldn't find anything'
 instead of stacktrace

---
 .../courses_crawler/show_basic.html.erb       | 24 +++++++++++--------
 .../projects_crawler/show_basic.html.erb      | 16 ++++++++-----
 .../theses_crawler/show_basic.html.erb        | 16 ++++++++-----
 3 files changed, 34 insertions(+), 22 deletions(-)

diff --git a/app/views/crawlers/courses_crawler/show_basic.html.erb b/app/views/crawlers/courses_crawler/show_basic.html.erb
index 01baf24..761b876 100644
--- a/app/views/crawlers/courses_crawler/show_basic.html.erb
+++ b/app/views/crawlers/courses_crawler/show_basic.html.erb
@@ -1,20 +1,24 @@
 <h1>Results for "<%= params[:search_term] %>"</h1>
 
 <ul class="courses-list">
-  <% @courses.each_with_index do |course| %>
-    <li class="course">
-      <%= link_to crawlers_courses_crawler_show_detail_url(:title => course['title'], :detail_url => course['detail_url']) do %>
-      <span class="list-link">
-          <span class="course-title">
-            <%= course['title'] %>
+  <% if @courses %>
+    <% @courses.each_with_index do |course| %>
+      <li class="course">
+        <%= link_to crawlers_courses_crawler_show_detail_url(:title => course['title'], :detail_url => course['detail_url']) do %>
+          <span class="list-link">
+              <span class="course-title">
+                <%= course['title'] %>
+              </span>
           </span>
-      </span>
-      <% end %>
-      <span class="add-to-fav">
+        <% end %>
+        <span class="add-to-fav">
         <%= link_to crawlers_courses_crawler_add_to_fav_url(:title => course['title'], :detail_url => course['detail_url']) do %>
           <%= show_svg('favorite-24px.svg') %>
         <% end %>
       </span>
-    </li>
+      </li>
+    <% end %>
+  <% else %>
+    Could not find anything... Please try again.
   <% end %>
 </ul>
diff --git a/app/views/crawlers/projects_crawler/show_basic.html.erb b/app/views/crawlers/projects_crawler/show_basic.html.erb
index 21e2bab..4b2b93f 100644
--- a/app/views/crawlers/projects_crawler/show_basic.html.erb
+++ b/app/views/crawlers/projects_crawler/show_basic.html.erb
@@ -1,20 +1,24 @@
 <h1>Results for "<%= params[:search_term] %>"</h1>
 
 <ul class="projects-list">
-  <% @projects.each_with_index do |project| %>
-    <li class="project">
-      <%= link_to crawlers_projects_crawler_show_detail_url(:id => project['id'], :title => project['title']) do %>
+  <% if @projects %>
+    <% @projects.each_with_index do |project| %>
+      <li class="project">
+        <%= link_to crawlers_projects_crawler_show_detail_url(:id => project['id'], :title => project['title']) do %>
       <span class="list-link">
           <span class="project-title">
             <%= project['title'] %>
           </span>
       </span>
-      <% end %>
-      <span class="add-to-fav">
+        <% end %>
+        <span class="add-to-fav">
         <%= link_to crawlers_projects_crawler_add_to_fav_url(:id => project['id'], :title => project['title']) do %>
           <%= show_svg('favorite-24px.svg') %>
         <% end %>
       </span>
-    </li>
+      </li>
+    <% end %>
+  <% else %>
+    Could not find anything... Please try again.
   <% end %>
 </ul>
diff --git a/app/views/crawlers/theses_crawler/show_basic.html.erb b/app/views/crawlers/theses_crawler/show_basic.html.erb
index 02ba658..ec624db 100644
--- a/app/views/crawlers/theses_crawler/show_basic.html.erb
+++ b/app/views/crawlers/theses_crawler/show_basic.html.erb
@@ -1,20 +1,24 @@
 <h1>Results for "<%= params[:search_term] %>"</h1>
 
 <ul class="theses-list">
-  <% @theses.each_with_index do |thesis| %>
-    <li class="thesis">
-      <%= link_to crawlers_theses_crawler_show_detail_url(:id => thesis['id'], :title => thesis['title']) do %>
+  <% if @theses %>
+    <% @theses.each_with_index do |thesis| %>
+      <li class="thesis">
+        <%= link_to crawlers_theses_crawler_show_detail_url(:id => thesis['id'], :title => thesis['title']) do %>
       <span class="list-link">
           <span class="thesis-title">
             <%= thesis['title'] %>
           </span>
       </span>
-      <% end %>
-      <span class="add-to-fav">
+        <% end %>
+        <span class="add-to-fav">
         <%= link_to crawlers_theses_crawler_add_to_fav_url(:id => thesis['id'], :title => thesis['title']) do %>
           <%= show_svg('favorite-24px.svg') %>
         <% end %>
       </span>
-    </li>
+      </li>
+    <% end %>
+  <% else %>
+    Could not find anything... Please try again.
   <% end %>
 </ul>