From 9dcb2994e16b57772e2af130bca941e99db0bf7b Mon Sep 17 00:00:00 2001 From: Pfingstfrosch Date: Sat, 16 May 2020 11:58:25 +0200 Subject: [PATCH] create a hash of favorite details and reuse it; move redirect_back out of conditional scope --- .../crawlers/people_crawler_controller.rb | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/app/controllers/crawlers/people_crawler_controller.rb b/app/controllers/crawlers/people_crawler_controller.rb index 4de86da..2b5be29 100644 --- a/app/controllers/crawlers/people_crawler_controller.rb +++ b/app/controllers/crawlers/people_crawler_controller.rb @@ -27,14 +27,17 @@ class Crawlers::PeopleCrawlerController < Crawlers::TissCrawlerController @person = TissCrawler.get_details(params) # create stores the object to the db after creation - if FavoritePerson.create(tiss_id: @person['tiss_id'], first_name: @person['first_name'], last_name: @person['last_name'], picture_uri: @person['picture_uri']).valid? - FavoritePerson.create(tiss_id: @person['tiss_id'], first_name: @person['first_name'], last_name: @person['last_name'], picture_uri: @person['picture_uri']) - flash[:alert] = "Person added to your favorites!" - redirect_back(fallback_location: search) + favorite_hash = { tiss_id: @person['tiss_id'], + first_name: @person['first_name'], + last_name: @person['last_name'], + picture_uri: @person['picture_uri'] } + if FavoritePerson.create(favorite_hash).valid? + FavoritePerson.create(favorite_hash) + flash[:alert] = 'Person added to your favorites!' else - flash[:alert] = "Person is already favorited!" - redirect_back(fallback_location: search) + flash[:alert] = 'Person is already favorited!' end + redirect_back(fallback_location: search) end end