Pfingstfrosch
31f437c37a
Fix styling issue with missing td cell
2020-06-04 19:25:51 +02:00
Pfingstfrosch
d52e844fa5
Reformat the delete buttons
2020-06-04 19:25:06 +02:00
Pfingstfrosch
b188b238b8
Reformat inputs
2020-06-04 19:24:56 +02:00
Pfingstfrosch
3e3ed87b18
Introduce and use print.css
2020-06-04 19:24:45 +02:00
Pfingstfrosch
c6073806de
lel
2020-05-31 17:25:48 +02:00
Pfingstfrosch
8cbf96742f
final styling of fav table buttons
2020-05-31 17:08:40 +02:00
Pfingstfrosch
1a94f5919d
final styling of table sorting
2020-05-31 17:02:34 +02:00
Pfingstfrosch
ad85619ccc
added sorting arrow for favorites view
2020-05-31 16:45:22 +02:00
Pfingstfrosch
cfcbf5acdb
Ad requirement 4
...
I have no idea how this requirement shall be implemented at the end, but at first step, the tiss_crawler.rb lib checks if the search_term is an empty string and returns an error msg if found
otherwise it returns the result, but appended to 'content' key
2020-05-31 15:48:17 +02:00
Pfingstfrosch
72b9f7d7a0
Don't allow empty search due to the course requirement 4
2020-05-31 15:17:56 +02:00
Pfingstfrosch
80bf9dbc5b
render search crawlers header as partial
2020-05-31 15:06:25 +02:00
Pfingstfrosch
fcc07a75b4
offer a back to search button
2020-05-31 14:25:41 +02:00
Pfingstfrosch
0a849a92e3
restyle fav subnav
2020-05-31 14:17:59 +02:00
Pfingstfrosch
2d8a2f8b7e
decrease size of titles, looks better on mobiles
...
change text, add information on which specific search you are
2020-05-31 13:59:11 +02:00
Pfingstfrosch
28a722e5e1
decrease size of titles, looks better on mobiles
2020-05-31 13:54:01 +02:00
Pfingstfrosch
15e2b25a50
better font for whole body
2020-05-31 13:52:01 +02:00
Pfingstfrosch
32ec7c49ff
make favorite view more mobile friendly
...
append buttons under each row of data instead besides
append a line which separates the tables beneath every odd line to group data and buttons
2020-05-31 13:50:07 +02:00
Pfingstfrosch
204597b39d
fix rubycop issue:
...
- don't introduce global variable
- don't prefix getter with get_
- single quotes instead of doubles for hash usage
2020-05-31 13:41:50 +02:00
Pfingstfrosch
831c78a3ff
Merge remote-tracking branch 'remotes/origin/projects_search' into fixes
...
# Conflicts:
# app/views/favorites/projects.html.erb
# db/schema.rb
2020-05-31 13:16:56 +02:00
Pfingstfrosch
724a13347c
Display 'Not implemented yet.'
2020-05-29 16:12:44 +02:00
Pfingstfrosch
84cf537412
Catch render errors and display 'Couldn't find anything' instead of stacktrace
2020-05-29 16:12:23 +02:00
Pfingstfrosch
f96ed67cf0
move buttons underneath the displayed lines to make the view more mobile compatible
2020-05-29 15:56:19 +02:00
Pfingstfrosch
a3f7066cc1
Merge branches 'projects_search' and 'user_based_+_sortable_favs'
...
# Conflicts:
# app/assets/stylesheets/favorites.scss
2020-05-29 15:48:58 +02:00
Pfingstfrosch
b47a37daea
Merge branch 'master' of https://gitlab.com/kranklyboy/tiss2go
2020-05-29 15:48:29 +02:00
Pfingstfrosch
47d47a51b7
styling of favorites
2020-05-29 15:48:11 +02:00
Pfingstfrosch
1f70049dc4
added arrows for sorting
2020-05-29 15:47:20 +02:00
a6a866d357
Hotfix: Add params parsing
...
When favoriting from `show_basic` for courses, the parameters `number`
and `semester` are not passed to the underlying function. Instead, the
`detail_url` is passed, which has to be parsed to get the `number` and
`semester`.
2020-05-29 10:57:18 +02:00
cbcc7c3d25
Hotfix: parse oid when only one given
...
The function `show_detail` for courses was expecting an array of
lecturer oids. When it got only one and therefore not an array but an
int, the line `@lecturers_oid.each` would fail to parse the variable
because it is not an array.
2020-05-29 10:43:34 +02:00
04245d63dc
Implement favoriting of projects
2020-05-29 10:29:20 +02:00
c9f93d6fd8
Do not parse HTML
...
Might allow an attacker (in this case someone creating a course in TISS)
to do some nasty HTML injection. But eeeh, who cares? ¯\_(ツ)_/¯
2020-05-27 20:07:04 +02:00
ae217a60ea
Fix comment errors
...
Should really look at it before doing copypasta...
2020-05-27 17:48:09 +02:00
f2ad597c94
Implement the basic search result page for projects
2020-05-27 17:47:41 +02:00
9c76ce0553
Implement a basic detail page for projects
2020-05-27 17:44:03 +02:00
bba13f249c
Implement show_basic, show_detail and add_to_fav methods
2020-05-27 17:18:23 +02:00
19eb7a724f
Add search context for projects
2020-05-27 17:09:25 +02:00
e359595d0f
Add advisor and assistant names to thesis detail view
2020-05-25 16:28:22 +02:00
b20cccf07b
Implement favorite view for theses
2020-05-25 16:20:27 +02:00
d84297bde7
Implement search, show_basic, show_detail and add_to_fav for theses
2020-05-25 16:14:41 +02:00
311e3d9dcb
Finish favorite courses view
2020-05-25 14:57:15 +02:00
2b8539cba9
Make table left/right scrollable
2020-05-23 16:15:40 +02:00
b53a1ebe81
Fix routing error for helpers
...
Due to moving the helpers into their own folder, the modules were not
defined properly anymore.
2020-05-23 15:50:31 +02:00
dabda63cbc
Remove URL parsing
...
The fields `courseNr` and `semesterCode` are already parsed by the
controller and do not have to be parsed again when calling the
add_to_fav function.
2020-05-23 15:44:39 +02:00
b8cc0d5b61
Implement favoriting of courses
2020-05-21 13:31:54 +02:00
Pfingstfrosch
1a4370c90e
doesn't work yet
2020-05-16 15:07:12 +02:00
Pfingstfrosch
b11ef548b6
style the table
2020-05-16 15:06:42 +02:00
Pfingstfrosch
6922f31bc5
remove unnecessary bloat
2020-05-16 14:29:30 +02:00
Pfingstfrosch
2f6d638cd1
second attempt of making favorite people view sortable
2020-05-16 14:09:33 +02:00
Pfingstfrosch
f2686288b7
moved into proper folder location
2020-05-16 14:09:11 +02:00
Pfingstfrosch
83d4368af7
first attempt of making favorite people view sortable
2020-05-16 13:30:00 +02:00
Pfingstfrosch
dd7ac8e64f
only select favorites which match the current user id
2020-05-16 12:26:21 +02:00
