zenon/tiss2go
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

create a hash of favorite details and reuse it;

Browse Source 
move redirect_back out of conditional scope
This commit is contained in:
Pfingstfrosch 2020-05-16 11:58:25 +02:00
parent 5bb0bae858
commit 9dcb2994e1
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
app/controllers/crawlers/people_crawler_controller.rb
View File

@ -27,14 +27,17 @@ class Crawlers::PeopleCrawlerController < Crawlers::TissCrawlerController
@person = TissCrawler.get_details(params)
# create stores the object to the db after creation
if FavoritePerson.create(tiss_id: @person['tiss_id'], first_name: @person['first_name'], last_name: @person['last_name'], picture_uri: @person['picture_uri']).valid?
FavoritePerson.create(tiss_id: @person['tiss_id'], first_name: @person['first_name'], last_name: @person['last_name'], picture_uri: @person['picture_uri'])
flash[:alert] = "Person added to your favorites!"
redirect_back(fallback_location: search)
favorite_hash = { tiss_id: @person['tiss_id'],
first_name: @person['first_name'],
last_name: @person['last_name'],
picture_uri: @person['picture_uri'] }
if FavoritePerson.create(favorite_hash).valid?
FavoritePerson.create(favorite_hash)
flash[:alert] = 'Person added to your favorites!'
else
flash[:alert] = "Person is already favorited!"
redirect_back(fallback_location: search)
flash[:alert] = 'Person is already favorited!'
end
redirect_back(fallback_location: search)
end
end