101 Commits

Author SHA1 Message Date
Pfingstfrosch
724a13347c Display 'Not implemented yet.' 2020-05-29 16:12:44 +02:00
Pfingstfrosch
84cf537412 Catch render errors and display 'Couldn't find anything' instead of stacktrace 2020-05-29 16:12:23 +02:00
Pfingstfrosch
f96ed67cf0 move buttons underneath the displayed lines to make the view more mobile compatible 2020-05-29 15:56:19 +02:00
Pfingstfrosch
a3f7066cc1 Merge branches 'projects_search' and 'user_based_+_sortable_favs'
# Conflicts:
#	app/assets/stylesheets/favorites.scss
2020-05-29 15:48:58 +02:00
Pfingstfrosch
b47a37daea Merge branch 'master' of https://gitlab.com/kranklyboy/tiss2go 2020-05-29 15:48:29 +02:00
Pfingstfrosch
47d47a51b7 styling of favorites 2020-05-29 15:48:11 +02:00
Pfingstfrosch
1f70049dc4 added arrows for sorting 2020-05-29 15:47:20 +02:00
a6a866d357 Hotfix: Add params parsing
When favoriting from `show_basic` for courses, the parameters `number`
and `semester` are not passed to the underlying function. Instead, the
`detail_url` is passed, which has to be parsed to get the `number` and
`semester`.
2020-05-29 10:57:18 +02:00
cbcc7c3d25 Hotfix: parse oid when only one given
The function `show_detail` for courses was expecting an array of
lecturer oids. When it got only one and therefore not an array but an
int, the line `@lecturers_oid.each` would fail to parse the variable
because it is not an array.
2020-05-29 10:43:34 +02:00
c9f93d6fd8 Do not parse HTML
Might allow an attacker (in this case someone creating a course in TISS)
to do some nasty HTML injection. But eeeh, who cares? ¯\_(ツ)_/¯
2020-05-27 20:07:04 +02:00
b12d161b0e Fix empty response 2020-05-27 20:03:24 +02:00
ae217a60ea Fix comment errors
Should really look at it before doing copypasta...
2020-05-27 17:48:09 +02:00
f2ad597c94 Implement the basic search result page for projects 2020-05-27 17:47:41 +02:00
9c76ce0553 Implement a basic detail page for projects 2020-05-27 17:44:03 +02:00
bba13f249c Implement show_basic, show_detail and add_to_fav methods 2020-05-27 17:18:23 +02:00
61933c23d4 Implement get_project_details 2020-05-27 17:11:01 +02:00
19eb7a724f Add search context for projects 2020-05-27 17:09:25 +02:00
3201628f2d Add routes for projects 2020-05-27 16:41:27 +02:00
e359595d0f Add advisor and assistant names to thesis detail view 2020-05-25 16:28:22 +02:00
b20cccf07b Implement favorite view for theses 2020-05-25 16:20:27 +02:00
d84297bde7 Implement search, show_basic, show_detail and add_to_fav for theses 2020-05-25 16:14:41 +02:00
311e3d9dcb Finish favorite courses view 2020-05-25 14:57:15 +02:00
2b8539cba9 Make table left/right scrollable 2020-05-23 16:15:40 +02:00
b53a1ebe81 Fix routing error for helpers
Due to moving the helpers into their own folder, the modules were not
defined properly anymore.
2020-05-23 15:50:31 +02:00
dabda63cbc Remove URL parsing
The fields `courseNr` and `semesterCode` are already parsed by the
controller and do not have to be parsed again when calling the
add_to_fav function.
2020-05-23 15:44:39 +02:00
b8cc0d5b61 Implement favoriting of courses 2020-05-21 13:31:54 +02:00
a43c2b8edb Merge remote-tracking branch 'origin/user_based_+_sortable_favs' into courses_search 2020-05-21 11:08:43 +02:00
52515549ee Hotfix: change inheritance to reflect new routes 2020-05-21 10:51:51 +02:00
Pfingstfrosch
1a4370c90e doesn't work yet 2020-05-16 15:07:12 +02:00
Pfingstfrosch
b11ef548b6 style the table 2020-05-16 15:06:42 +02:00
Pfingstfrosch
6922f31bc5 remove unnecessary bloat 2020-05-16 14:29:30 +02:00
Pfingstfrosch
2f6d638cd1 second attempt of making favorite people view sortable 2020-05-16 14:09:33 +02:00
Pfingstfrosch
f2686288b7 moved into proper folder location 2020-05-16 14:09:11 +02:00
Pfingstfrosch
83d4368af7 first attempt of making favorite people view sortable 2020-05-16 13:30:00 +02:00
Pfingstfrosch
dd7ac8e64f only select favorites which match the current user id 2020-05-16 12:26:21 +02:00
Pfingstfrosch
72be2d07f3 store also the user_id when adding to favorite 2020-05-16 12:22:09 +02:00
Pfingstfrosch
8ca0f74276 added user_id to favorite_people model 2020-05-16 12:21:48 +02:00
Pfingstfrosch
9dcb2994e1 create a hash of favorite details and reuse it;
move redirect_back out of conditional scope
2020-05-16 11:58:25 +02:00
Pfingstfrosch
5bb0bae858 fix of inheritance error -> uninitialized constant Crawlers::ApplicationController 2020-05-16 11:45:05 +02:00
Pfingstfrosch
1970a65bf8 fix of inheritance error -> uninitialized constant TissCrawlerController 2020-05-16 11:44:21 +02:00
Pfingstfrosch
d5ec02201d instead of redirecting just display an success or error message after pressing add button 2020-05-12 20:01:30 +02:00
Pfingstfrosch
49be25838e remove route with no purpose 2020-05-12 19:57:12 +02:00
Pfingstfrosch
34f34790ee remove action with no purpose 2020-05-12 19:53:17 +02:00
Pfingstfrosch
d34a3d583c refactored crawler controllers and bundled them in crawlers namespace 2020-05-12 19:49:18 +02:00
Pfingstfrosch
d7907a3a0c remove helpers with no controller class related 2020-05-12 19:29:12 +02:00
Pfingstfrosch
415ed22f6e remove HOME Page, because redundant
show search page as default
2020-05-12 19:27:43 +02:00
Pfingstfrosch
16ae8fd87b update 2020-05-12 19:19:08 +02:00
Pfingstfrosch
92eff82f1a refactored favorites:
instead of using a fav page for each content, use a general favorites pane where the user can select which favs shall be shown
2020-05-12 19:19:04 +02:00
Pfingstfrosch
a8f4d4a9db Main nav bar now contains 3 menus:
- Home
- Search TISS
- Your Favorites
2020-05-12 19:17:13 +02:00
Pfingstfrosch
ae6a202e59 refactored routes file:
now using namespaces to make the file more readable and better structured
2020-05-12 19:16:18 +02:00